Optimation MailjetTransport.php #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 10, 2018 10:35
kachar
reviewed
Apr 19, 2018
| // Create mailjetClient | ||
| $mailjetClient = $this->createMailjetClient(); | ||
|
|
||
| $this->createMailjetClient(); |
There was a problem hiding this comment.
This line has no effect at the moment. We create new client instance and throw it into space.
I suggest we move the creation of the client before the foreach loop and keep the is_null condition.
// Create mailjetClient
if (is_null($this->mailjetClient)) {
$this->mailjetClient = $this->createMailjetClient();
}
foreach ($messages as $message) {
// ...
}This will have performance gain as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in issue #16 mentioned the following got optimized:
PHPDocs:
Logic:
Variables:
All tests are passed.